× Please submit new Bug Reports on GitHub: github.com/Jensen-Technologies/component-creator-issues/issues

1 month plan

7 years 7 months ago #722 by Cedric
1 month plan was created by Cedric
Hello,

First i like this tool, saved several hours.

I bought the one month support plan and I have 2 issues:

 - where is the module builder?
 - the generated code have a lot of problems, as sample the xml files, are totaly wrong generated (too many line breaks, line break missing, wrong alignement, ...), the php code is fine, but many probles, some times there is a line break before the { and some times not.... And indentation should be tab not, spaces... 
 - the file header comment should be a template.

This is a good tool, but not perfect, there is not many missing to become perfect.

Rick

Please Log in or Create an account to join the conversation.

7 years 7 months ago #725 by Cedric
Replied by Cedric on topic 1 month plan
? ;-)


$app = JFactory::getApplication();
$editId = JFactory::getApplication()->input->getInt('id', null, 'array');

should be:
$app = JFactory::getApplication();
$editId =  $app->input->getInt('id', null, 'array'); 

Please Log in or Create an account to join the conversation.

7 years 7 months ago - 7 years 7 months ago #726 by David Villena
Replied by David Villena on topic 1 month plan
Hi Rick.

First of all, thank you very much for your feedback. Component Creator wouldn't be so awesome without the huge team of testers that you guys are ;)

You're right about the code formatting; we're so focused on features, functionality and bug fixes that sometime we forget that code must look pretty and well-aligned for readability. We have a job on the queue to revise all the code generated and fix all format issues.
However, we can't agree about indentation: Joomla! coding standards , are based (with modifications) on PSR-2 Coding Style Guide , and there it is written:

2.4. Indenting
Code MUST use an indent of 4 spaces, and MUST NOT use tabs for indenting.

N.b.: Using only spaces, and not mixing spaces with tabs, helps to avoid problems with diffs, patches, history, and annotations. The use of spaces also makes it easy to insert fine-grained sub-indentation for inter-line alignment.

About the Module Builder, on the Configuration view of your component you can find a checkbox with the label "Include Module" that, if checked, makes Component Creator to generate the structure of an empty module, that you can fill with the functionality that you need for it. Screenshot is attached.

And we've solved the $app unused thing.

Best regards,

David.
Attachments:
Last edit: 7 years 7 months ago by David Villena.

Please Log in or Create an account to join the conversation.

7 years 7 months ago #728 by Cedric
Replied by Cedric on topic 1 month plan

Please Log in or Create an account to join the conversation.

7 years 7 months ago #733 by David Villena
Replied by David Villena on topic 1 month plan
Hi, 

It appears that you're right, we'll change the indentation any time soon.

Regards,

David.

Please Log in or Create an account to join the conversation.

Time to create page: 0.166 seconds
Powered by Kunena Forum

We use cookies so that you can place orders and we can provide a better service. You can control the use of cookies at the individual browser level. If you reject cookies, you may still use our website, but your ability to use some features or areas of our website may be limited.